linux-kernel - Re: [PATCH v2 02/12] reboot: reboot, not shutdown, on hw_protection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z432-IV0VTgnl7Rf@google.com>
Date: Mon, 20 Jan 2025 07:10:48 +0000
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Fabio Estevam <festevam@...x.de>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>,
	Jonathan Corbet <corbet@....net>, Serge Hallyn <serge@...lyn.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Matti Vaittinen <mazziesaccount@...il.com>,
	Benson Leung <bleung@...omium.org>,
	Guenter Roeck <groeck@...omium.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	chrome-platform@...ts.linux.dev, devicetree@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH v2 02/12] reboot: reboot, not shutdown, on
 hw_protection_reboot timeout

On Mon, Jan 13, 2025 at 05:25:27PM +0100, Ahmad Fatoum wrote:
> hw_protection_shutdown() will kick off an orderly shutdown and if that
> takes longer than a configurable amount of time, an emergency shutdown
> will occur.
> 
> Recently, hw_protection_reboot() was added for those systems that don't
> implement a proper shutdown and are better served by rebooting and
> having the boot firmware worry about doing something about the critical
> condition.
> 
> On timeout of the orderly reboot of hw_protection_reboot(), the system
> would go into shutdown, instead of reboot. This is not a good idea, as
> going into shutdown was explicitly not asked for.
> 
> Fix this by always doing an emergency reboot if hw_protection_reboot()
> is called and the orderly reboot takes too long.
> 
> Fixes: 79fa723ba84c ("reboot: Introduce thermal_zone_device_critical_reboot()")
> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>

Reviewed-by: Tzung-Bi Shih <tzungbi@...nel.org>