linux-kernel - Re: [PATCH v2 07/12] reboot: add support for configuring emergency hardware protection action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z433SVbr-h3JCycF@google.com>
Date: Mon, 20 Jan 2025 07:12:09 +0000
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Fabio Estevam <festevam@...x.de>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>,
	Jonathan Corbet <corbet@....net>, Serge Hallyn <serge@...lyn.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Matti Vaittinen <mazziesaccount@...il.com>,
	Benson Leung <bleung@...omium.org>,
	Guenter Roeck <groeck@...omium.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	chrome-platform@...ts.linux.dev, devicetree@...r.kernel.org,
	kernel@...gutronix.de, Matteo Croce <mcroce@...rosoft.com>
Subject: Re: [PATCH v2 07/12] reboot: add support for configuring emergency
 hardware protection action

On Mon, Jan 13, 2025 at 05:25:32PM +0100, Ahmad Fatoum wrote:
> We currently leave the decision of whether to shutdown or reboot to
> protect hardware in an emergency situation to the individual drivers.
> 
> This works out in some cases, where the driver detecting the critical
> failure has inside knowledge: It binds to the system management controller
> for example or is guided by hardware description that defines what to do.
> 
> In the general case, however, the driver detecting the issue can't know
> what the appropriate course of action is and shouldn't be dictating the
> policy of dealing with it.
> 
> Therefore, add a global hw_protection toggle that allows the user to
> specify whether shutdown or reboot should be the default action when the
> driver doesn't set policy.
> 
> This introduces no functional change yet as hw_protection_trigger() has
> no callers, but these will be added in subsequent commits.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>

With a minor comment,
Reviewed-by: Tzung-Bi Shih <tzungbi@...nel.org>

> diff --git a/Documentation/ABI/testing/sysfs-kernel-reboot b/Documentation/ABI/testing/sysfs-kernel-reboot
> index 837330fb251134ffdf29cd68f0b2a845b088e5a0..133f54707d533665c68a5946394540ec50b149e5 100644
> --- a/Documentation/ABI/testing/sysfs-kernel-reboot
> +++ b/Documentation/ABI/testing/sysfs-kernel-reboot
> @@ -30,3 +30,11 @@ KernelVersion:	5.11
>  Contact:	Matteo Croce <mcroce@...rosoft.com>
>  Description:	Don't wait for any other CPUs on reboot and
>  		avoid anything that could hang.
> +
> +What:		/sys/kernel/reboot/hw_protection
> +Date:		Feb 2025
> +KernelVersion:	6.14

The info might need to be adjusted if the series would be for 6.15.