linux-kernel - Re: [PATCH v2 09/12] platform/chrome: cros_ec_lpc: prepare for hw_protection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z433aYZ1JB_t5jrb@google.com>
Date: Mon, 20 Jan 2025 07:12:41 +0000
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Fabio Estevam <festevam@...x.de>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>,
	Jonathan Corbet <corbet@....net>, Serge Hallyn <serge@...lyn.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Matti Vaittinen <mazziesaccount@...il.com>,
	Benson Leung <bleung@...omium.org>,
	Guenter Roeck <groeck@...omium.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	chrome-platform@...ts.linux.dev, devicetree@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH v2 09/12] platform/chrome: cros_ec_lpc: prepare for
 hw_protection_shutdown removal

On Mon, Jan 13, 2025 at 05:25:34PM +0100, Ahmad Fatoum wrote:
> In the general case, a driver doesn't know which of system shutdown or
> reboot is the better action to take to protect hardware in an emergency
> situation. For this reason, hw_protection_shutdown is going to be
> removed in favor of hw_protection_trigger, which defaults to shutdown,
> but may be configured at kernel runtime to be a reboot instead.
> 
> The ChromeOS EC situation is different as we do know that shutdown is
> the correct action as the EC is programmed to force reset after the
> short period, thus replace hw_protection_shutdown with
> __hw_protection_trigger with HWPROT_ACT_SHUTDOWN as argument to
> maintain the same behavior.
> 
> No functional change.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>

Acked-by: Tzung-Bi Shih <tzungbi@...nel.org>