linux-kernel - Re: [PATCH v3 1/5] dt-bindings: pinctrl: Add support for Amlogic SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d08136ac-e08f-4e5d-b562-78529f34d86f@kernel.org>
Date: Mon, 20 Jan 2025 08:21:49 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Xianwei Zhao <xianwei.zhao@...ogic.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>,
 Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 Bartosz Golaszewski <brgl@...ev.pl>, linux-gpio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH v3 1/5] dt-bindings: pinctrl: Add support for Amlogic SoCs

On 20/01/2025 06:57, Xianwei Zhao wrote:
> Hi Krzysztof,
>     Thanks for reply.
> 
> On 2025/1/17 16:48, Krzysztof Kozlowski wrote:
>> [ EXTERNAL EMAIL ]
>>
>> On Wed, Jan 15, 2025 at 02:41:59PM +0800, Xianwei Zhao wrote:
>>> +properties:
>>> +  compatible:
>>> +    const: amlogic,pinctrl-a4
>>> +
>>> +  "#address-cells":
>>> +    const: 2
>>> +
>>> +  "#size-cells":
>>> +    const: 2
>>
>> Why this moved to '2'? 32-bit was not enough?
>>
> Previously only represented a register address offset value, now 
> directly represents a register, through 'ranges" which to represent. 
> 32-bit is enough, but since APB bus is defined as 64-bit, here is 

Changelog was silent on this.

> following. I increase support for 32-bit. Like the following values:

No, just keep one of these.



Best regards,
Krzysztof