linux-kernel - Re: [PATCH] selftests/capabilities/test_execve: Initialize the variable have_outer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4549965-bb0c-4b46-b796-265704290e42@collabora.com>
Date: Mon, 20 Jan 2025 12:31:22 +0500
From: Muhammad Usama Anjum <Usama.Anjum@...labora.com>
To: liuye <liuye@...inos.cn>, shuah@...nel.org
Cc: Usama.Anjum@...labora.com, amer.shanawany@...il.com,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/capabilities/test_execve: Initialize the
 variable have_outer_privilege

On 1/14/25 10:41 AM, liuye wrote:
>     Uninitialized variable: have_outer_privilege.
>     Fix it.
Please improve the description. Explain how the current code
is wrong. After that add:
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> 
> Signed-off-by: liuye <liuye@...inos.cn>
> ---
>  tools/testing/selftests/capabilities/test_execve.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/capabilities/test_execve.c b/tools/testing/selftests/capabilities/test_execve.c
> index 47bad7ddc5bc..c9617b38d6f7 100644
> --- a/tools/testing/selftests/capabilities/test_execve.c
> +++ b/tools/testing/selftests/capabilities/test_execve.c
> @@ -83,7 +83,7 @@ static bool create_and_enter_ns(uid_t inner_uid)
>  	uid_t outer_uid;
>  	gid_t outer_gid;
>  	int i, ret;
> -	bool have_outer_privilege;
> +	bool have_outer_privilege = false;
>  
>  	outer_uid = getuid();
>  	outer_gid = getgid();


-- 
BR,
Muhammad Usama Anjum