linux-kernel - Re: [PATCH 2/9] mips: dts: realtek: Clean up CPU clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44dd0df0-90d4-401d-bf13-3d51188118df@alliedtelesis.co.nz>
Date: Mon, 20 Jan 2025 14:21:21 +1300
From: Chris Packham <chris.packham@...iedtelesis.co.nz>
To: Sander Vanheule <sander@...nheule.net>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 devicetree@...r.kernel.org, linux-mips@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/9] mips: dts: realtek: Clean up CPU clocks

Hi Sander,

On 20/01/2025 07:34, Sander Vanheule wrote:
> The referenced CPU clock does not require any additional #clock-cells,
> so drop the extraneous '0' in the referenced CPU clock.
>
> The binding for MIPS cpus also does not allow for the clock-names
> property, so just drop it.
>
> This resolves some error message from 'dtbs_check':
>      cpu@0: clocks: [[4], [0]] is too long
>      'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Sander Vanheule <sander@...nheule.net>
Reviewed-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
Tested-by: Chris Packham <chris.packham@...iedtelesis.co.nz> # For RTL9302C
> ---
>   arch/mips/boot/dts/realtek/rtl838x.dtsi | 3 +--
>   arch/mips/boot/dts/realtek/rtl930x.dtsi | 3 +--
>   2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/mips/boot/dts/realtek/rtl838x.dtsi b/arch/mips/boot/dts/realtek/rtl838x.dtsi
> index 722106e39194..d2c6baabb38c 100644
> --- a/arch/mips/boot/dts/realtek/rtl838x.dtsi
> +++ b/arch/mips/boot/dts/realtek/rtl838x.dtsi
> @@ -9,8 +9,7 @@ cpu@0 {
>   			device_type = "cpu";
>   			compatible = "mips,mips4KEc";
>   			reg = <0>;
> -			clocks = <&baseclk 0>;
> -			clock-names = "cpu";
> +			clocks = <&baseclk>;
>   		};
>   	};
>   
> diff --git a/arch/mips/boot/dts/realtek/rtl930x.dtsi b/arch/mips/boot/dts/realtek/rtl930x.dtsi
> index 67261d6fcaa7..f2e57ea3a60c 100644
> --- a/arch/mips/boot/dts/realtek/rtl930x.dtsi
> +++ b/arch/mips/boot/dts/realtek/rtl930x.dtsi
> @@ -26,8 +26,7 @@ cpu@0 {
>   			device_type = "cpu";
>   			compatible = "mips,mips34Kc";
>   			reg = <0>;
> -			clocks = <&baseclk 0>;
> -			clock-names = "cpu";
> +			clocks = <&baseclk>;
>   		};
>   	};
>