linux-kernel - Re: [PATCH] Bluetooth: Add ABI doc for sysfs reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ad410cf-f4f1-4519-96fe-9a2a07865963@molgen.mpg.de>
Date: Mon, 20 Jan 2025 09:32:16 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Hsin-chen Chuang <chharry@...gle.com>
Cc: linux-bluetooth@...r.kernel.org, luiz.dentz@...il.com,
 chromeos-bluetooth-upstreaming@...omium.org,
 Hsin-chen Chuang <chharry@...omium.org>,
 Johan Hedberg <johan.hedberg@...il.com>,
 Marcel Holtmann <marcel@...tmann.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: Add ABI doc for sysfs reset

Dear Hsin-chen,


Thank you for your patch.


Am 20.01.25 um 09:24 schrieb Hsin-chen Chuang:
> From: Hsin-chen Chuang <chharry@...omium.org>
> 
> The functionality was implemented in commit 0f8a00137411 ("Bluetooth:
> Allow reset via sysfs")

Add a Fixes: tag?

> Signed-off-by: Hsin-chen Chuang <chharry@...omium.org>
> ---
> 
>   Documentation/ABI/stable/sysfs-class-bluetooth | 9 +++++++++
>   MAINTAINERS                                    | 1 +
>   2 files changed, 10 insertions(+)
>   create mode 100644 Documentation/ABI/stable/sysfs-class-bluetooth
> 
> diff --git a/Documentation/ABI/stable/sysfs-class-bluetooth b/Documentation/ABI/stable/sysfs-class-bluetooth
> new file mode 100644
> index 000000000000..e794ce706582
> --- /dev/null
> +++ b/Documentation/ABI/stable/sysfs-class-bluetooth
> @@ -0,0 +1,9 @@
> +What: 		/sys/class/bluetooth/hci<index>/reset
> +Date:		14-Jan-2025
> +KernelVersion:	6.13
> +Contact:	linux-bluetooth@...r.kernel.org
> +Description: 	This write-only attribute allows users to trigger the vendor reset
> +		method on the Bluetooth device when an arbitrary data is written.

*data* is plural, so “when arbitrary data is written”?

> +		The reset may or may not be done through the device transport
> +		(e.g., UART/USB), and can through an out-of-band approach such as

…, and can *also be done* through …

> +		GPIO.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 797e94ba74f7..e949c3ac7846 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4058,6 +4058,7 @@ S:	Supported
>   W:	http://www.bluez.org/
>   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git
>   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git
> +F:	Documentation/ABI/stable/sysfs-class-bluetooth
>   F:	include/net/bluetooth/
>   F:	net/bluetooth/
>   


Kind regards,

Paul