linux-kernel - Re: [PATCH v1] irqchip/irq-mvebu-icu: Fix irq_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cyghan60.ffs@tglx>
Date: Mon, 20 Jan 2025 09:45:43 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Stefan Eichenberger <eichest@...il.com>
Cc: andrew@...n.ch, gregory.clement@...tlin.com,
 sebastian.hesselbarth@...il.com, shivamurthy.shastri@...utronix.de,
 anna-maria@...utronix.de, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] irqchip/irq-mvebu-icu: Fix irq_set_type for sei and nsr

On Fri, Jan 17 2025 at 19:03, Stefan Eichenberger wrote:
> It seems that irq_chip_set_type_parent is not failing. By adding some
> debug messages to kernel/irq/manage.c I found that irqd_get_trigger_type
> returns IRQF_TRIGGER_RISING even though it should return
> IRQF_TRIGGER_HIGH according to the device tree. Maybe this was fixed
> between 6.10 and 6.12 but I need to analyze that again in more detail.

The trigger type is fixed up in mvebu_icu_irq_domain_translate(), but
that should be the same with the new code in mvebu_icu_translate().

Can you instrument mvebu_icu_translate() and validate that it is

    1) Invoked at all

    2) The type fixup is done:

       if (msi_data->subset_data->icu_group == ICU_GRP_SEI)
              *type = IRQ_TYPE_EDGE_RISING;

Thanks,

        tglx