linux-kernel - Re: [PATCH] efistub: add efi=quiet parameter to selectively silence efistub alone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXFKSrVx4SO_T8sHU=4hie8pjk8CUWQDV8oh+bz=xMn4rw@mail.gmail.com>
Date: Mon, 20 Jan 2025 09:54:49 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: "Hendrik 'T4cC0re' Meyer" <linux@....dev>
Cc: linux-doc@...r.kernel.org, linux-efi@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] efistub: add efi=quiet parameter to selectively silence
 efistub alone

On Mon, 20 Jan 2025 at 09:53, Hendrik 'T4cC0re' Meyer <linux@....dev> wrote:
>
> > I'd prefer to just raise the verbosity level of those messages instead.
>
> Agreed. I'll send in a new patch setting the verbosity of those messages one
> above the default.
>

Actually, let's do it the other way around. Does the below work for you?



--- a/drivers/firmware/efi/libstub/printk.c
+++ b/drivers/firmware/efi/libstub/printk.c
@@ -5,13 +5,13 @@
 #include <linux/ctype.h>
 #include <linux/efi.h>
 #include <linux/kernel.h>
-#include <linux/printk.h> /* For CONSOLE_LOGLEVEL_* */
+#include <linux/kern_levels.h>
 #include <asm/efi.h>
 #include <asm/setup.h>

 #include "efistub.h"

-int efi_loglevel = CONSOLE_LOGLEVEL_DEFAULT;
+int efi_loglevel = LOGLEVEL_NOTICE;

 /**
  * efi_char16_puts() - Write a UCS-2 encoded string to the console