linux-kernel - [RFC 1/1] mm/madvise: fail MADV_PAGEOUT on VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250120013038.6657-1-ioworker0@gmail.com>
Date: Mon, 20 Jan 2025 09:30:38 +0800
From: Lance Yang <ioworker0@...il.com>
To: akpm@...ux-foundation.org
Cc: 21cnbao@...il.com,
	ryan.roberts@....com,
	dev.jain@....com,
	david@...hat.com,
	shy828301@...il.com,
	ziy@...dia.com,
	libang.li@...group.com,
	baolin.wang@...ux.alibaba.com,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	Liam.Howlett@...cle.com,
	lorenzo.stoakes@...cle.com,
	vbabka@...e.cz,
	jannh@...gle.com,
	Jason@...c4.com,
	Lance Yang <ioworker0@...il.com>,
	Mingzhe Yang <mingzhe.yang@...com>
Subject: [RFC 1/1] mm/madvise: fail MADV_PAGEOUT on VM_DROPPABLE VMA

MADV_PAGEOUT should fail on VMAs with the VM_DROPPABLE flag. While
MADV_PAGEOUT is intended to move anonymous pages to swap, VM_DROPPABLE
should not be swapped out.

There is an issue where using MADV_PAGEOUT on a VMA with the VM_DROPPABLE
flag behaves like MADV_DONTNEED, causing the pages to be dropped. This
could break the semantics of MADV_PAGEOUT, IMO.

So, let's add a check to detect the VM_DROPPABLE flag before doing
MADV_PAGEOUT and returns -EINVAL.

Fixes: 9651fcedf7b9 ("mm: add MAP_DROPPABLE for designating always lazily freeable mappings")
Signed-off-by: Mingzhe Yang <mingzhe.yang@...com>
Signed-off-by: Lance Yang <ioworker0@...il.com>
---
 mm/madvise.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/madvise.c b/mm/madvise.c
index 49f3a75046f6..29d0234da8a1 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -1263,6 +1263,8 @@ static int madvise_vma_behavior(struct vm_area_struct *vma,
 	case MADV_COLD:
 		return madvise_cold(vma, prev, start, end);
 	case MADV_PAGEOUT:
+		if (vma->vm_flags & VM_DROPPABLE)
+			return -EINVAL;
 		return madvise_pageout(vma, prev, start, end);
 	case MADV_FREE:
 	case MADV_DONTNEED:
-- 
2.45.2