linux-kernel - Re: [PATCH v4 5/5] platform/x86: acer-wmi: Ignore AC events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f9f5d603-e391-47a8-adf4-d2e0c5a6836b@linux.intel.com>
Date: Mon, 20 Jan 2025 14:43:58 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: David Wang <00107082@....com>
cc: w_armin@....de, farhan.anwar8@...il.com, 
    Hans de Goede <hdegoede@...hat.com>, jlee@...e.com, kuurtb@...il.com, 
    LKML <linux-kernel@...r.kernel.org>, platform-driver-x86@...r.kernel.org, 
    rayanmargham4@...il.com
Subject: Re: [PATCH v4 5/5] platform/x86: acer-wmi: Ignore AC events

On Sat, 14 Dec 2024, David Wang wrote:

> May I suggest pr_info() this WMID_AC_EVENT event, there were discussions
> about possible unstable adapter cord causing flood of events 8-0/1. The
> logs may help identify the cause.

I don't think flood of pr_info() would be desired if that's the case. 
While one could ratelimit the print out, it still seems useless noise for 
normal operation which this patch aimed to eliminate.

It sounds more like you'd want to print something if and only if a flood 
is detected (how to determine what is "flood", I don't know enough details 
of this particular case)?

In any case, if feels something that would be better put into own a patch 
with a proper justification and explanation what constitutes as "flood".

-- 
 i.