linux-kernel - Re: [PATCH] drm/panfrost: Drop redundant Mediatek driver data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <15006d4c-81ac-4691-b817-d6510992a14a@collabora.com>
Date: Mon, 20 Jan 2025 13:58:24 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Boris Brezillon <boris.brezillon@...labora.com>,
 Rob Herring <robh@...nel.org>, Steven Price <steven.price@....com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Matthias Brugger <matthias.bgg@...il.com>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] drm/panfrost: Drop redundant Mediatek driver data

Il 18/01/25 17:06, Krzysztof Kozlowski ha scritto:
> mediatek_mt8192_supplies are exactly the same as
> mediatek_mt8183_b_supplies.  mediatek_mt8188_data is exactly the same as
> &mediatek_mt8183_b_data.  There is never point in duplicating all these
> structures - it only raises questions or encourages bugs when someone
> updates one variant without changing the other.  Drop duplicated code.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

The reason why these are different is that 8183 and 8192 have different
GPU architectures, where the former is bifrost and the latter is valhall.

Regardless, even if there actually was a reason for that, I agree about
this deduplication here, as the architecture is anyway made clear by the
devicetree bindings for those SoCs.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Cheers!