linux-kernel - Re: [PATCH] greybus: gb-beagleplay: Add error handling for gb_greybus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b92676e-b970-4e0c-aeaa-b28faf5ff39c@beagleboard.org>
Date: Mon, 20 Jan 2025 20:12:36 +0530
From: Ayush Singh <ayush@...gleboard.org>
To: Wentao Liang <vulab@...as.ac.cn>, gregkh@...uxfoundation.org
Cc: elder@...nel.org, johan@...nel.org, lee@...nel.org,
 francesco.dolcini@...adex.com, viro@...iv.linux.org.uk,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] greybus: gb-beagleplay: Add error handling for
 gb_greybus_init

On 1/20/25 19:35, Wentao Liang wrote:

> Add error handling for the gb_greybus_init(bg) function call
> during the firmware reflash process to maintain consistency
> in error handling throughout the codebase. If initialization
> fails, log an error and return FW_UPLOAD_ERR_RW_ERROR.
>
> Fixes: 0cf7befa3ea2 ("greybus: gb-beagleplay: Add firmware upload API")
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
> ---
>   drivers/greybus/gb-beagleplay.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/greybus/gb-beagleplay.c b/drivers/greybus/gb-beagleplay.c
> index 473ac3f2d382..da31f1131afc 100644
> --- a/drivers/greybus/gb-beagleplay.c
> +++ b/drivers/greybus/gb-beagleplay.c
> @@ -912,7 +912,9 @@ static enum fw_upload_err cc1352_prepare(struct fw_upload *fw_upload,
>   		cc1352_bootloader_reset(bg);
>   		WRITE_ONCE(bg->flashing_mode, false);
>   		msleep(200);
> -		gb_greybus_init(bg);
> +		if (gb_greybus_init(bg) < 0)
> +			return dev_err_probe(&bg->sd->dev, FW_UPLOAD_ERR_RW_ERROR,
> +					     "Failed to initialize greybus");
>   		gb_beagleplay_start_svc(bg);
>   		return FW_UPLOAD_ERR_FW_INVALID;
>   	}

Looks good to me.

Reviewed-by: Ayush Singh <ayush@...gleboard.org>