linux-kernel - Re: [PATCH] hwmon: ina238: Add support for shunt voltage scaling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef0741d5-832e-4c15-ae45-f4efcf4bc443@roeck-us.net>
Date: Mon, 20 Jan 2025 08:38:29 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Potin Lai <potin.lai.pt@...il.com>, Jean Delvare <jdelvare@...e.com>,
 Patrick Williams <patrick@...cx.xyz>
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
 Cosmo Chou <cosmo.chou@...ntatw.com>, Potin Lai <potin.lai@...ntatw.com>
Subject: Re: [PATCH] hwmon: ina238: Add support for shunt voltage scaling

On 1/20/25 08:23, Potin Lai wrote:
> The INA238 sensor reports shunt voltage with microvolt precision.
> However, the hwmon driver currently exposes this value only in
> millivolts via `in0_input`, which results in a loss of precision for
> readings within the range of ±1 mV.
> 
> This patch introduces an `in0_scale` attribute to provide the scaling
> factor applied to the shunt voltage reading. By exposing this attribute,
> users can accurately interpret the in0_input values in microvolts,
> preserving the sensor's full precision.
> 
> Signed-off-by: Potin Lai <potin.lai.pt@...il.com>

Sorry, this is an ABI violation and thus a no-go. in0_input is and will
always be reported in mV.

Guenter