linux-kernel - Re: [PATCH v4 3/3] drm/vkms: Switch to dynamic allocation for CRTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z46HL-eSSA2EsPCi@louis-chauvet-laptop>
Date: Mon, 20 Jan 2025 18:26:07 +0100
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: José Expósito <jose.exposito89@...il.com>
Cc: airlied@...il.com, dri-devel@...ts.freedesktop.org,
	hamohammed.sa@...il.com, linux-kernel@...r.kernel.org,
	maarten.lankhorst@...ux.intel.com, mairacanal@...eup.net,
	melissa.srw@...il.com, mripard@...nel.org,
	rodrigosiqueiramelo@...il.com, simona.vetter@...ll.ch,
	simona@...ll.ch, thomas.petazzoni@...tlin.com, tzimmermann@...e.de
Subject: Re: [PATCH v4 3/3] drm/vkms: Switch to dynamic allocation for CRTC

On 20/01/25 - 17:23, José Expósito wrote:
> > A specific allocation for the CRTC is not strictly necessary at this
> > point, but in order to implement dynamic configuration of VKMS (configFS),
> > it will be easier to have one allocation per CRTC.
> > 
> > Reviewed-by: Maxime Ripard <mripard@...nel.org>
> > Signed-off-by: Louis Chauvet <louis.chauvet@...tlin.com>
> > ---

[...]

> > +	/* Initialize the writeback component */
> >  	if (vkmsdev->config->writeback) {
> > -		writeback = vkms_enable_writeback_connector(vkmsdev, crtc);
> > +		writeback = vkms_enable_writeback_connector(vkmsdev, output);
> >  		if (writeback)
> >  			DRM_ERROR("Failed to init writeback connector\n");
> >  	}
> 
> Hi Louis,
> 
> Thanks for fixing this error condition.
> 
> I have been working and running automated tests on top of this series and
> I haven't found any other issue.
> 
> Reviewed-by: José Expósito <jose.exposito89@...il.com>

Thanks a lot! I will merge this tomorrow.

What is your automated tests series? 

I will also send tomorrow a new rebased iteration for:
- https://patchwork.freedesktop.org/series/140786/
- https://patchwork.freedesktop.org/series/133698/
- https://patchwork.freedesktop.org/patch/625883/

If someone can look on them and leave some reviews, I will be very happy 
to apply them!

I will also send a first version of the configFS work (two distincts 
series to make the review easier). 

Thanks a lot,
Louis Chauvet