linux-kernel - Re: [PATCH V2 02/23] ASoC: amd: acp70: add acp pci driver for ACP7.0 and ACP7.1 platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bde9986f-9519-4e2d-b435-dc15a96f299c@amd.com>
Date: Mon, 20 Jan 2025 23:03:59 +0530
From: "Mukunda,Vijendar" <vijendar.mukunda@....com>
To: Mark Brown <broonie@...nel.org>
Cc: alsa-devel@...a-project.org, lgirdwood@...il.com, perex@...ex.cz,
 tiwai@...e.com, Basavaraj.Hiregoudar@....com, Sunil-kumar.Dommati@....com,
 venkataprasad.potturu@....com, Mario.Limonciello@....com,
 linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 02/23] ASoC: amd: acp70: add acp pci driver for ACP7.0
 and ACP7.1 platforms

On 20/01/25 22:38, Mark Brown wrote:
> On Mon, Jan 20, 2025 at 03:31:09PM +0530, Vijendar Mukunda wrote:
>
>> This patch adds common PCI driver to bind to this device and get PCI
>> resources for ACP7.0 & ACP7.1 platforms.
>> +	ret = pci_request_regions(pci, "AMD ACP6.2 audio");
>> +	if (ret < 0) {
>> +		dev_err(&pci->dev, "pci_request_regions failed\n");
>> +		goto disable_pci;
>> +	}
> Looks like there's a cut'n'paste that needed to be updated here!  I'd
> suggest there might be some chance for code sharing, but I suspect the
> amount of code is so trivial that it's not really worth it.
Will update it. As platform specific changes exists along with
standard pci driver probe sequence, I don't think we really need to
go for common code here. Same time, We will improve code by
implementing common helper functions where ever it can be applicable.