linux-kernel - Re: [PATCH] wifi: brcmfmac: use random seed flag for BCM4355 and BCM4364 firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19484c927b8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
Date: Mon, 20 Jan 2025 18:36:03 +0100
From: Arend Van Spriel <arend.vanspriel@...adcom.com>
To: Aditya Garg <gargaditya08@...e.com>, Arend van Spriel <aspriel@...il.com>, Kalle Valo <kvalo@...nel.org>, Hector Martin <marcan@...can.st>, Janne Grunau <j@...nau.net>
CC: Orlando Chamberlain <orlandoch.dev@...il.com>, <stable@...r.kernel.org>, <linux-wireless@...r.kernel.org>, <brcm80211@...ts.linux.dev>, <brcm80211-dev-list.pdl@...adcom.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wifi: brcmfmac: use random seed flag for BCM4355 and BCM4364 firmware

On January 20, 2025 5:50:56 PM Aditya Garg <gargaditya08@...e.com> wrote:

> From: Aditya Garg <gargaditya08@...e.com>
>
> Before 6.13, random seed to the firmware was given based on the logic
> whether the device had valid OTP or not, and such devices were found
> mainly on the T2 and Apple Silicon Macs. In 6.13, the logic was changed,
> and the device table was used for this purpose, so as to cover the special
> case of BCM43752 chip.
>
> During the transition, the device table for BCM4364 and BCM4355 Wi-Fi chips
> which had valid OTP was not modified, thus breaking Wi-Fi on these devices.
> This patch adds does the necessary changes, similar to the ones done for
> other chips.
>
> Fixes: ea11a89c3ac6 ("wifi: brcmfmac: add flag for random seed during 
> firmware download")
> Cc: stable@...r.kernel.org

Acked-by: Arend van Spriel  <arend.vanspriel@...adcom.com>
> Signed-off-by: Aditya Garg <gargaditya08@...e.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)