linux-kernel - Re: [PATCH] tracing: Fix #if CONFIG_MODULES to #ifdef CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250120130900.09a5ffba@gandalf.local.home>
Date: Mon, 20 Jan 2025 13:09:00 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: LKML <linux-kernel@...r.kernel.org>, Linux Trace Kernel
 <linux-trace-kernel@...r.kernel.org>
Cc: Masami Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, Linus Torvalds
 <torvalds@...ux-foundation.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] tracing: Fix #if CONFIG_MODULES to #ifdef
 CONFIG_MODULES

On Mon, 20 Jan 2025 12:57:45 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> From: Steven Rostedt <rostedt@...dmis.org>
> 
> A typo was introduced when adding the ":mod:" command that did
> a "#if CONFIG_MODULES" instead of a "#ifdef CONFIG_MODULES".
> Fix it.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501110319.xY9ltUxL-lkp@intel.com/

Cut and paste error. Wrong closes: Should have been:

  Closes: https://lore.kernel.org/oe-kbuild-all/202501190121.E2CIJuUj-lkp@intel.com/

-- Steve


> Fixes: b355247df104e ("tracing: Cache ":mod:" events for modules not loaded yet")
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> ---
>  kernel/trace/trace_events.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index f762e554fad4..bb1406719c3f 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -857,7 +857,7 @@ static int ftrace_event_enable_disable(struct trace_event_file *file,
>  	return __ftrace_event_enable_disable(file, enable, 0);
>  }
>  
> -#if CONFIG_MODULES
> +#ifdef CONFIG_MODULES
>  struct event_mod_load {
>  	struct list_head	list;
>  	char			*module;