linux-kernel - Re: [PATCH 7/7] arm64: dts: qcom: x1e80100: enable rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6ff6f2e-9280-4fd0-af4c-f50b35652800@oldschoolsolutions.biz>
Date: Mon, 20 Jan 2025 19:12:05 +0100
From: Jens Glathe <jens.glathe@...schoolsolutions.biz>
To: Johan Hovold <johan+linaro@...nel.org>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Bjorn Andersson <andersson@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>,
 Jonathan Marek <jonathan@...ek.ca>, linux-arm-msm@...r.kernel.org,
 linux-rtc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] arm64: dts: qcom: x1e80100: enable rtc

Hi Johan,

On 20.01.25 15:41, Johan Hovold wrote:
> On many Qualcomm platforms the PMIC RTC control and time registers are
> read-only so that the RTC time can not be updated. Instead an offset
> needs be stored in some machine-specific non-volatile memory, which a
> driver can take into account.
>
> On X1E based Windows on Arm machines the offset is stored in a Qualcomm
> specific UEFI variable.
>
> Unlike on previous platforms the alarm registers are also unaccessible
> on X1E as they are owned by the ADSP.
>
> Assume all X1E machines use similar firmware and enable the RTC in the
> PMIC dtsi for now.
>
> Based on a patch by Jonathan Marek. [1]
>
> Link: https://lore.kernel.org/r/20241015004945.3676-4-jonathan@marek.ca # [1]
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
>   arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
> index 5b54ee79f048..051fb3a304b9 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
> @@ -223,8 +223,8 @@ pmk8550_rtc: rtc@...0 {
>   			reg = <0x6100>, <0x6200>;
>   			reg-names = "rtc", "alarm";
>   			interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>;
> -			/* Not yet sure what blocks access */
> -			status = "reserved";
> +			qcom,no-alarm; /* alarm owned by ADSP */
> +			qcom,uefi-rtc-info;
>   		};
>
>   		pmk8550_sdam_2: nvram@...0 {

works nicely on SnapDragon Dev Kit X1E001DE. Thank you!

Tested-by: Jens Glathe <jens.glathe@...schoolsolutions.biz>

with best regards

Jens Glathe