linux-kernel - Re: [PATCH] drm/panel: samsung-s6e88a0-ams452ef01: transition to mipi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=Ver0_CFH=pvHH4DO7aN5wsdPbFmo-42Q44z6MA9O8nzA@mail.gmail.com>
Date: Tue, 21 Jan 2025 12:59:51 -0800
From: Doug Anderson <dianders@...omium.org>
To: Tejas Vipin <tejasvipin76@...il.com>
Cc: neil.armstrong@...aro.org, maarten.lankhorst@...ux.intel.com, 
	mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch, 
	quic_jesszhan@...cinc.com, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: samsung-s6e88a0-ams452ef01: transition to
 mipi_dsi wrapped functions

Hi,

On Tue, Jan 21, 2025 at 5:48 AM Tejas Vipin <tejasvipin76@...il.com> wrote:
>
> @@ -136,12 +113,8 @@ static int s6e88a0_ams452ef01_prepare(struct drm_panel *panel)
>  static int s6e88a0_ams452ef01_unprepare(struct drm_panel *panel)
>  {
>         struct s6e88a0_ams452ef01 *ctx = to_s6e88a0_ams452ef01(panel);
> -       struct device *dev = &ctx->dsi->dev;
> -       int ret;
>
> -       ret = s6e88a0_ams452ef01_off(ctx);
> -       if (ret < 0)
> -               dev_err(dev, "Failed to un-initialize panel: %d\n", ret);
> +       s6e88a0_ams452ef01_off(ctx);

Can you change s6e88a0_ams452ef01_off() to return "void" instead of
"int" since the caller (correctly) doesn't check the error code here
now?

With that:

Reviewed-by: Douglas Anderson <dianders@...omium.org>