linux-kernel - Re: Build failure with GCC 15 (-std=gnu23)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877c6n24wj.fsf@gentoo.org>
Date: Tue, 21 Jan 2025 22:11:56 +0000
From: Sam James <sam@...too.org>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Kees Cook <kees@...nel.org>,  Masahiro Yamada <masahiroy@...nel.org>,
  Kostadin Shishmanov <kostadinshishmanov@...tonmail.com>,
  "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
  arnd@...db.de,  linux-kbuild@...r.kernel.org
Subject: Re: Build failure with GCC 15 (-std=gnu23)

Nathan Chancellor <nathan@...nel.org> writes:

> On Mon, Jan 20, 2025 at 04:16:30PM -0800, Kees Cook wrote:
>> On Wed, Nov 20, 2024 at 03:28:35AM +0900, Masahiro Yamada wrote:
>> > Some Makefile overriding KBUILD_CFLAGS would forget to add
>> > $(CSTD_FLAG), for the same reason as they would forget to add
>> > -std=gnu11.
>> 
>> But at least we'd have 1 place to change when we changed the std level.
>> 
>> FWIW, I just ran into this build failure too testing GCC 15 from their
>> ToT. Both EFI and compressed Makefiles needed it in my build.
>
> Yeah, I suggested the simpler diff in a separate thread, which seems to
> agree with your testing:
>
> https://lore.kernel.org/20250120182048.GA3244701@ax162/
>
> I don't mind drafting up a commit message and sending those along if
> that would be preferrable.

At this point, I'd like to see the scattered -std= in given it seems
less objectionable, even if I'd prefer one place, as we already missed
one release being GCC 15-buildable. Happy to test/ack it if you're willing to send it.

thanks,
sam