[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z484U1gDYolJ8CAm@black.fi.intel.com>
Date: Tue, 21 Jan 2025 08:01:55 +0200
From: Raag Jadav <raag.jadav@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v1 2/2] iio: imu: st_lsm9ds0: Replace device.h with what
is needed
On Tue, Dec 03, 2024 at 09:48:52PM +0200, Andy Shevchenko wrote:
> Instead of including a huge device.h with tons of dependencies
> include only what driver actually uses.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c | 2 +-
> drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c
> index d03cec3b24fe..2b1b57761688 100644
> --- a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c
> +++ b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c
> @@ -7,7 +7,7 @@
> * Author: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> */
>
> -#include <linux/device.h>
> +#include <linux/device/devres.h>
> #include <linux/err.h>
> #include <linux/gfp_types.h>
> #include <linux/i2c.h>
> diff --git a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c
> index 69e9135795a3..d3bfd74a69ab 100644
> --- a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c
> +++ b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c
> @@ -7,7 +7,7 @@
> * Author: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> */
>
> -#include <linux/device.h>
> +#include <linux/device/devres.h>
> #include <linux/err.h>
> #include <linux/gfp_types.h>
> #include <linux/module.h>
Isn't struct device still used in these files?
Raag
Powered by blists - more mailing lists