linux-kernel - Re: [PATCH v4 1/2] dt-bindings: arm: Update compatible for remote etm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250121-prudent-cornflower-owl-261faa@krzk-bin>
Date: Tue, 21 Jan 2025 09:56:24 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mao Jinlong <quic_jinlmao@...cinc.com>
Cc: Suzuki K Poulose <suzuki.poulose@....com>, 
	Mike Leach <mike.leach@...aro.org>, James Clark <james.clark@...aro.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, 
	linux-kernel@...r.kernel.org, coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: Update compatible for remote etm

On Tue, Jan 21, 2025 at 02:38:59PM +0800, Mao Jinlong wrote:
> Use different compatible to distinguish between different remote
> etms.

Why?

Every second time for qcom. Don't say what, we see that easily.

> 
> Signed-off-by: Mao Jinlong <quic_jinlmao@...cinc.com>
> ---
>  .../bindings/arm/qcom,coresight-remote-etm.yaml       | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
> index 4fd5752978cd..199f2ca4b8a9 100644
> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
> @@ -18,7 +18,14 @@ description:
>  
>  properties:
>    compatible:
> -    const: qcom,coresight-remote-etm
> +    contains:

No, you are now saying this is "qcom,pink-pony" as well...

Sorry, this change is neither explained, nor correct.

> +      enum:
> +        - qcom,coresight-modem-etm
> +        - qcom,coresight-wcn-etm
> +        - qcom,coresight-adsp-etm
> +        - qcom,coresight-sensor-etm
> +        - qcom,coresight-modem2-etma

And how anyone can understand the difference between modem and modem2?

NAK for entire patch in this form.

Best regards,
Krzysztof