linux-kernel - Re: [PATCH v2 6/8] ext4: update the descriptions of data_err=abort and data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ibyxhbx3y3cbkt6pjn4th7omtflsba7xi6pwbbqq3xhokshdvb@j5s524uarmoo>
Date: Tue, 21 Jan 2025 12:14:19 +0100
From: Jan Kara <jack@...e.cz>
To: libaokun@...weicloud.com
Cc: linux-ext4@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, 
	jack@...e.cz, linux-kernel@...r.kernel.org, yi.zhang@...wei.com, 
	yangerkun@...wei.com, Baokun Li <libaokun1@...wei.com>
Subject: Re: [PATCH v2 6/8] ext4: update the descriptions of data_err=abort
 and data_err=ignore

On Tue 21-01-25 15:10:48, libaokun@...weicloud.com wrote:
> From: Baokun Li <libaokun1@...wei.com>
> 
> We now print error messages in ext4_end_bio() when page writeback
> encounters an error. If data_err=abort is set, the journal will also
> be aborted in a kworker. This means that we now check all Buffer I/O
> in all modes and decide whether to abort the journal based on the
> data_err option. Therefore, we remove the ordered mode restriction
> in the descriptions of data_err=abort and data_err=ignore.
> 
> Signed-off-by: Baokun Li <libaokun1@...wei.com>
> Reviewed-by: Zhang Yi <yi.zhang@...wei.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  Documentation/admin-guide/ext4.rst | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/admin-guide/ext4.rst b/Documentation/admin-guide/ext4.rst
> index 2418b0c2d3df..b857eb6ca1b6 100644
> --- a/Documentation/admin-guide/ext4.rst
> +++ b/Documentation/admin-guide/ext4.rst
> @@ -238,11 +238,10 @@ When mounting an ext4 filesystem, the following option are accepted:
>          configured using tune2fs)
>  
>    data_err=ignore(*)
> -        Just print an error message if an error occurs in a file data buffer in
> -        ordered mode.
> +        Just print an error message if an error occurs in a file data buffer.
> +
>    data_err=abort
> -        Abort the journal if an error occurs in a file data buffer in ordered
> -        mode.
> +        Abort the journal if an error occurs in a file data buffer.
>  
>    grpid | bsdgroups
>          New objects have the group ID of their parent.
> -- 
> 2.39.2
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR