linux-kernel - Re: [PATCH] ocfs2: Fix incorrect CPU endianness conversion causing mount failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <020e497f-54d2-44d5-aee5-625cb430de6b@linux.alibaba.com>
Date: Tue, 21 Jan 2025 19:33:28 +0800
From: Joseph Qi <joseph.qi@...ux.alibaba.com>
To: Heming Zhao <heming.zhao@...e.com>, akpm <akpm@...ux-foundation.org>
Cc: ocfs2-devel@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ocfs2: Fix incorrect CPU endianness conversion causing
 mount failure



On 2025/1/21 19:22, Heming Zhao wrote:
> Commit 23aab037106d ("ocfs2: fix UBSAN warning in ocfs2_verify_volume()")
> introduced a regression bug. The blksz_bits value is already converted
> to CPU endian in the previous code; therefore, the code shouldn't use
> le32_to_cpu() anymore.
> 
> Fixes: 23aab037106d ("ocfs2: fix UBSAN warning in ocfs2_verify_volume()")
> Signed-off-by: Heming Zhao <heming.zhao@...e.com>

Thanks for pointing out this issue.

Reviewed-by: Joseph Qi <joseph.qi@...ux.alibaba.com>

> ---
>  fs/ocfs2/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index c79b4291777f..1e87554f6f41 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -2340,7 +2340,7 @@ static int ocfs2_verify_volume(struct ocfs2_dinode *di,
>  			mlog(ML_ERROR, "found superblock with incorrect block "
>  			     "size bits: found %u, should be 9, 10, 11, or 12\n",
>  			     blksz_bits);
> -		} else if ((1 << le32_to_cpu(blksz_bits)) != blksz) {
> +		} else if ((1 << blksz_bits) != blksz) {
>  			mlog(ML_ERROR, "found superblock with incorrect block "
>  			     "size: found %u, should be %u\n", 1 << blksz_bits, blksz);
>  		} else if (le16_to_cpu(di->id2.i_super.s_major_rev_level) !=