linux-kernel - Re: [PATCH 1/2] arm64: dts: qcom: sa8775p: Delete duplicate fastrpc nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7boe423isk36f6z2cqor7oj2y63t6cdo5gpfvjsioqhg4yqyjc@sitfdraxfjot>
Date: Tue, 21 Jan 2025 13:59:22 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Ling Xu <quic_lxu5@...cinc.com>
Cc: andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, quic_kuiw@...cinc.com, 
	quic_ekangupt@...cinc.com, quic_kartsana@...cinc.com, kernel@...cinc.com, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sa8775p: Delete duplicate fastrpc
 nodes

On Tue, Jan 21, 2025 at 05:24:03PM +0530, Ling Xu wrote:
> There are some items come out to be same value if we do SID & ~MASK.
> Remove duplicate compute-cb nodes for sa8775p to simplify.

No, you are not removing duplicate compute-cb nodes, you are removing
extra entries from the iommus property.

> 
> Signed-off-by: Ling Xu <quic_lxu5@...cinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 240 +++-----------------------
>  1 file changed, 24 insertions(+), 216 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 9da62d7c4d27..0aa27db21f3d 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -4517,15 +4517,7 @@ compute-cb@1 {
>  						compatible = "qcom,fastrpc-compute-cb";
>  						reg = <1>;
>  						iommus = <&apps_smmu 0x2141 0x04a0>,
> -							 <&apps_smmu 0x2161 0x04a0>,
> -							 <&apps_smmu 0x2181 0x0400>,
> -							 <&apps_smmu 0x21c1 0x04a0>,
> -							 <&apps_smmu 0x21e1 0x04a0>,
> -							 <&apps_smmu 0x2541 0x04a0>,
> -							 <&apps_smmu 0x2561 0x04a0>,
> -							 <&apps_smmu 0x2581 0x0400>,
> -							 <&apps_smmu 0x25c1 0x04a0>,
> -							 <&apps_smmu 0x25e1 0x04a0>;
> +							 <&apps_smmu 0x2181 0x0400>;
>  						dma-coherent;
>  					};
>  

-- 
With best wishes
Dmitry