linux-kernel - Re: [PATCH 1/7] ext4: convert EXT4_FLAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32851fb9-faf6-4321-bcd1-911cfa180228@huawei.com>
Date: Tue, 21 Jan 2025 20:15:28 +0800
From: Baokun Li <libaokun1@...wei.com>
To: Jan Kara <jack@...e.cz>
CC: <linux-ext4@...r.kernel.org>, <tytso@....edu>, <adilger.kernel@...ger.ca>,
	<linux-kernel@...r.kernel.org>, <yi.zhang@...wei.com>,
	<yangerkun@...wei.com>, Baokun Li <libaokun1@...wei.com>, Baokun Li
	<libaokun@...weicloud.com>
Subject: Re: [PATCH 1/7] ext4: convert EXT4_FLAGS_* defines to enum

On 2025/1/21 20:07, Jan Kara wrote:
> On Fri 17-01-25 16:23:09, libaokun@...weicloud.com wrote:
>> From: Baokun Li <libaokun1@...wei.com>
>>
>> Do away with the defines and use an enum as it's cleaner.
>>
>> Signed-off-by: Baokun Li <libaokun1@...wei.com>
> Yeah, why not. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@...e.cz>
>
> 								Honza
Thank you for the review!
>> ---
>>   fs/ext4/ext4.h | 8 +++++---
>>   1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
>> index 4e7de7eaa374..612208527512 100644
>> --- a/fs/ext4/ext4.h
>> +++ b/fs/ext4/ext4.h
>> @@ -2232,9 +2232,11 @@ extern int ext4_feature_set_ok(struct super_block *sb, int readonly);
>>   /*
>>    * Superblock flags
>>    */
>> -#define EXT4_FLAGS_RESIZING	0
>> -#define EXT4_FLAGS_SHUTDOWN	1
>> -#define EXT4_FLAGS_BDEV_IS_DAX	2
>> +enum {
>> +	EXT4_FLAGS_RESIZING,	/* Avoid superblock update and resize race */
>> +	EXT4_FLAGS_SHUTDOWN,	/* Prevent access to the file system */
>> +	EXT4_FLAGS_BDEV_IS_DAX	/* Current block device support DAX */
> 			      ^^ we usually put comma here so that future
> additions doesn't need to modify this line.
Okay, I will add a comma here in the next version.

Thanks,
Baokun
>> +};
>>   
>>   static inline int ext4_forced_shutdown(struct super_block *sb)
>>   {
>> -- 
>> 2.39.2
>>