linux-kernel - Re: [PATCH v1 1/2] media: dt-bindings: update clocks for sc7280-camss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c985b741-35db-4e3b-8fe4-8d2085371033@kernel.org>
Date: Tue, 21 Jan 2025 13:55:02 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vikram Sharma <quic_vikramsa@...cinc.com>, rfoss@...nel.org,
 todor.too@...il.com, bryan.odonoghue@...aro.org, mchehab@...nel.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 akapatra@...cinc.com, hariramp@...cinc.com, andersson@...nel.org,
 konradybcio@...nel.org, hverkuil-cisco@...all.nl,
 cros-qcom-dts-watchers@...omium.org, catalin.marinas@....com, will@...nel.org
Cc: linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@...cinc.com
Subject: Re: [PATCH v1 1/2] media: dt-bindings: update clocks for sc7280-camss

On 21/01/2025 13:09, Vikram Sharma wrote:
> This patch change clock names to make it consistent with


Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95


> existing platforms as gcc_cam_hf_axi -> gcc_axi_hf.

Which ones? sm8250 uses different.

> This also adds gcc_axi_sf and remove gcc_camera_ahb.

Why?

> 
> This change will not break ABI because the ABI hasn't
> been cemented yet as the dtsi changes are not merged
> yet and there are no users for this driver as of now.

So why did you wait till it gets to this merge window? Or is there some
sort of history here which you hid? The user was merged to media tree
and it is going to be merged for RC1.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597


Best regards,
Krzysztof