| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Z4+jwDBrZNRgu85S@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
Date: Tue, 21 Jan 2025 14:40:16 +0100
From: Alexander Gordeev <agordeev@...ux.ibm.com>
To: Joel Granados <joel.granados@...nel.org>
Cc: Thomas Weißschuh <linux@...ssschuh.net>,
Kees Cook <kees@...nel.org>, Luis Chamberlain <mcgrof@...nel.org>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org,
linux-s390@...r.kernel.org, linux-crypto@...r.kernel.org,
openipmi-developer@...ts.sourceforge.net,
intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
intel-xe@...ts.freedesktop.org, linux-hyperv@...r.kernel.org,
linux-rdma@...r.kernel.org, linux-raid@...r.kernel.org,
linux-scsi@...r.kernel.org, linux-serial@...r.kernel.org,
xen-devel@...ts.xenproject.org, linux-aio@...ck.org,
linux-fsdevel@...r.kernel.org, netfs@...ts.linux.dev,
codalist@...a.cs.cmu.edu, linux-mm@...ck.org,
linux-nfs@...r.kernel.org, ocfs2-devel@...ts.linux.dev,
fsverity@...ts.linux.dev, linux-xfs@...r.kernel.org,
io-uring@...r.kernel.org, bpf@...r.kernel.org,
kexec@...ts.infradead.org, linux-trace-kernel@...r.kernel.org,
linux-hardening@...r.kernel.org, apparmor@...ts.ubuntu.com,
linux-security-module@...r.kernel.org, keyrings@...r.kernel.org,
Song Liu <song@...nel.org>,
"Steven Rostedt (Google)" <rostedt@...dmis.org>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
"Darrick J. Wong" <djwong@...nel.org>,
Jani Nikula <jani.nikula@...el.com>,
Corey Minyard <cminyard@...sta.com>
Subject: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable
On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Granados wrote:
Hi Joel,
> Add the const qualifier to all the ctl_tables in the tree except for
> watchdog_hardlockup_sysctl, memory_allocation_profiling_sysctls,
> loadpin_sysctl_table and the ones calling register_net_sysctl (./net,
> drivers/inifiniband dirs). These are special cases as they use a
> registration function with a non-const qualified ctl_table argument or
> modify the arrays before passing them on to the registration function.
>
> Constifying ctl_table structs will prevent the modification of
> proc_handler function pointers as the arrays would reside in .rodata.
> This is made possible after commit 78eb4ea25cd5 ("sysctl: treewide:
> constify the ctl_table argument of proc_handlers") constified all the
> proc_handlers.
I could identify at least these occurences in s390 code as well:
diff --git a/arch/s390/appldata/appldata_base.c b/arch/s390/appldata/appldata_base.c
index dd7ba7587dd5..9b83c318f919 100644
--- a/arch/s390/appldata/appldata_base.c
+++ b/arch/s390/appldata/appldata_base.c
@@ -204,7 +204,7 @@ appldata_timer_handler(const struct ctl_table *ctl, int write,
{
int timer_active = appldata_timer_active;
int rc;
- struct ctl_table ctl_entry = {
+ const struct ctl_table ctl_entry = {
.procname = ctl->procname,
.data = &timer_active,
.maxlen = sizeof(int),
@@ -237,7 +237,7 @@ appldata_interval_handler(const struct ctl_table *ctl, int write,
{
int interval = appldata_interval;
int rc;
- struct ctl_table ctl_entry = {
+ const struct ctl_table ctl_entry = {
.procname = ctl->procname,
.data = &interval,
.maxlen = sizeof(int),
@@ -269,7 +269,7 @@ appldata_generic_handler(const struct ctl_table *ctl, int write,
struct list_head *lh;
int rc, found;
int active;
- struct ctl_table ctl_entry = {
+ const struct ctl_table ctl_entry = {
.data = &active,
.maxlen = sizeof(int),
.extra1 = SYSCTL_ZERO,
diff --git a/arch/s390/kernel/hiperdispatch.c b/arch/s390/kernel/hiperdispatch.c
index 7857a7e8e56c..7d0ba16085c1 100644
--- a/arch/s390/kernel/hiperdispatch.c
+++ b/arch/s390/kernel/hiperdispatch.c
@@ -273,7 +273,7 @@ static int hiperdispatch_ctl_handler(const struct ctl_table *ctl, int write,
{
int hiperdispatch;
int rc;
- struct ctl_table ctl_entry = {
+ const struct ctl_table ctl_entry = {
.procname = ctl->procname,
.data = &hiperdispatch,
.maxlen = sizeof(int),
diff --git a/arch/s390/kernel/topology.c b/arch/s390/kernel/topology.c
index 6691808bf50a..26e50de83d80 100644
--- a/arch/s390/kernel/topology.c
+++ b/arch/s390/kernel/topology.c
@@ -629,7 +629,7 @@ static int topology_ctl_handler(const struct ctl_table *ctl, int write,
int enabled = topology_is_enabled();
int new_mode;
int rc;
- struct ctl_table ctl_entry = {
+ const struct ctl_table ctl_entry = {
.procname = ctl->procname,
.data = &enabled,
.maxlen = sizeof(int),
@@ -658,7 +658,7 @@ static int polarization_ctl_handler(const struct ctl_table *ctl, int write,
{
int polarization;
int rc;
- struct ctl_table ctl_entry = {
+ const struct ctl_table ctl_entry = {
.procname = ctl->procname,
.data = &polarization,
.maxlen = sizeof(int),
diff --git a/arch/s390/mm/cmm.c b/arch/s390/mm/cmm.c
index 939e3bec2db7..8e354c90a3dd 100644
--- a/arch/s390/mm/cmm.c
+++ b/arch/s390/mm/cmm.c
@@ -263,7 +263,7 @@ static int cmm_pages_handler(const struct ctl_table *ctl, int write,
void *buffer, size_t *lenp, loff_t *ppos)
{
long nr = cmm_get_pages();
- struct ctl_table ctl_entry = {
+ const struct ctl_table ctl_entry = {
.procname = ctl->procname,
.data = &nr,
.maxlen = sizeof(long),
@@ -283,7 +283,7 @@ static int cmm_timed_pages_handler(const struct ctl_table *ctl, int write,
loff_t *ppos)
{
long nr = cmm_get_timed_pages();
- struct ctl_table ctl_entry = {
+ const struct ctl_table ctl_entry = {
.procname = ctl->procname,
.data = &nr,
.maxlen = sizeof(long),
> Best regards,
> --
> Joel Granados <joel.granados@...nel.org>
Thanks!
Powered by blists - more mailing lists