linux-kernel - Re: [PATCH V3] dt-bindings: serial: Add a new compatible string for UMS9632

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173746706432.2493664.199542333902610683.robh@kernel.org>
Date: Tue, 21 Jan 2025 07:44:24 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Wenhua Lin <Wenhua.Lin@...soc.com>
Cc: linux-kernel@...r.kernel.org, Xiongpeng Wu <xiongpeng.wu@...soc.com>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Jiri Slaby <jirislaby@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
 Cixi Geng <cixi.geng@...ux.dev>, devicetree@...r.kernel.org, 
 wenhua lin <wenhua.lin1994@...il.com>, Chunyan Zhang <zhang.lyra@...il.com>, 
 Zhirong Qiu <Zhirong.Qiu@...soc.com>, Zhaochen Su <Zhaochen.Su@...soc.com>, 
 Orson Zhai <orsonzhai@...il.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Baolin Wang <baolin.wang@...ux.alibaba.com>, linux-serial@...r.kernel.org
Subject: Re: [PATCH V3] dt-bindings: serial: Add a new compatible string
 for UMS9632


On Tue, 21 Jan 2025 19:54:04 +0800, Wenhua Lin wrote:
> The UART IP version of the ums9632 SoC project has been upgraded.
> UART controller registers have added valid bits to support new features.
> In order to distinguish different UART IP versions, we use sc9632-uart
> to represent upgraded IP and sc9836-uart to represent old IP.
> 
> Signed-off-by: Wenhua Lin <Wenhua.Lin@...soc.com>
> ---
> V2->V3 changes:
> * Lists are ordered by fallback.
> * Combine two const items into enum.
> * Change commit message.
> 
> V1->V2 changes:
> * Modify the compatible string of enum.
> * Change commit message.
> ---
>  Documentation/devicetree/bindings/serial/sprd-uart.yaml | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/serial/sprd-uart.yaml:30:10: [warning] wrong indentation: expected 10 but found 9 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250121115404.3612588-1-Wenhua.Lin@unisoc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.