linux-kernel - Re: [PATCH v4] serial: sc16is7xx: Fix IRQ number check behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250121092408.eb0c58293ef0d8907056c816@hugovil.com>
Date: Tue, 21 Jan 2025 09:24:08 -0500
From: Hugo Villeneuve <hugo@...ovil.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Andre Werner <andre.werner@...tec-electronic.com>,
 gregkh@...uxfoundation.org, jirislaby@...nel.org, hvilleneuve@...onoff.com,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
 lech.perczak@...lingroup.com, Maarten.Brock@...ls.nl
Subject: Re: [PATCH v4] serial: sc16is7xx: Fix IRQ number check behavior

On Tue, 21 Jan 2025 15:33:30 +0200
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Tue, Jan 21, 2025 at 08:18:19AM +0100, Andre Werner wrote:
> > The logical meaning of the previous version is wrong due to a typo.
> > 
> > If the IRQ equals 0, no interrupt pin is available and polling mode
> > shall be used.
> > 
> > Additionally, this fix adds a check for IRQ < 0 to increase robustness,
> > because documentation still says that negative IRQ values cannot be
> > absolutely ruled-out.
> > 
> > Fixes: 104c1b9dde9d859dd01bd2d ("serial: sc16is7xx: Add polling mode if no IRQ pin is available")
> 
> > 
> 
> This blank line is redundant (should not exists in the tag block).
> Otherwise LGTM, thanks for pursuing this!
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Reviewed-by: Hugo Villeneuve <hvilleneuve@...onoff.com>

-- 
Hugo Villeneuve