linux-kernel - Re: [PATCH 5/7] spi: zynqmp-gqspi: Split the bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1310bb6-48ef-4bdf-a359-f34b0d849a4d@sirena.org.uk>
Date: Tue, 21 Jan 2025 16:01:09 +0000
From: Mark Brown <broonie@...nel.org>
To: Sean Anderson <sean.anderson@...ux.dev>
Cc: "Mahapatra, Amit Kumar" <amit.kumar-mahapatra@....com>,
	"Simek, Michal" <michal.simek@....com>,
	"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
	Jinjie Ruan <ruanjinjie@...wei.com>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	"amitrkcian2002@...il.com" <amitrkcian2002@...il.com>,
	"git (AMD-Xilinx)" <git@....com>
Subject: Re: [PATCH 5/7] spi: zynqmp-gqspi: Split the bus

On Tue, Jan 21, 2025 at 10:53:53AM -0500, Sean Anderson wrote:
> On 1/21/25 08:19, Mahapatra, Amit Kumar wrote:

> > IMHO, restricting users to fixed names is not ideal. A better approach would be to 
> > introduce a Device Tree (DT) property for the bus number and select the bus 
> > accordingly.

> Why? It's not an artificial restriction; it reflects the hardware. And this is how
> SPI busses are typically represented. If you have two SPI busses, there should be
> two devicetree nodes.

Perhaps the thing is more that the buses are named instead of numbered?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)