linux-kernel - Re: [PATCH v2] i2c: iproc: Refactor prototype and remove redundant error checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <rv3ej2tdmfff2qilnpgvef64ujrozuplu7ix54rpd25kbrbhwd@zm5sjyn2vjra>
Date: Tue, 21 Jan 2025 18:50:19 +0100
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: andi.shyti@...nel.org, rjui@...adcom.com, sbranden@...adcom.com, 
	bcm-kernel-feedback-list@...adcom.com, linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i2c: iproc: Refactor prototype and remove redundant
 error checks

Hello,

On Tue, Jan 21, 2025 at 04:48:18PM +0800, Wentao Liang wrote:
> The bcm_iproc_i2c_init() always returns 0. As a result, there
> is no need to check its return value or handle errors.
> 
> This patch changes the prototype of bcm_iproc_i2c_init() to
> return void and removes the redundant error handling code after
> calls to bcm_iproc_i2c_init() in both the bcm_iproc_i2c_probe()
> and bcm_iproc_i2c_resume().
> 
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>

LGTM:

Acked-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)