[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250121101107.349a565b@kernel.org>
Date: Tue, 21 Jan 2025 10:11:07 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Huacai Chen <chenhuacai@...nel.org>
Cc: Qunqin Zhao <zhaoqunqin@...ngson.cn>, andrew+netdev@...n.ch,
davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
si.yanteng@...ux.dev, fancer.lancer@...il.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: dwmac-loongson: Add fix_soc_reset function
On Tue, 21 Jan 2025 17:29:37 +0800 Huacai Chen wrote:
> Hi, Qunqin,
>
> The patch itself looks good to me, but something can be improved.
> 1. The title can be "net: stmmac: dwmac-loongson: Add fix_soc_reset() callback"
> 2. You lack a "." at the end of the commit message.
> 3. Add a "Cc: stable@...r.kernel.org" because it is needed to backport
> to 6.12/6.13.
Please don't top post.
Powered by blists - more mailing lists