linux-kernel - Re: kernel build error due to large stack frame in __bch2_str_hash_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG48ez0NOpCp1HkD55v8QCmjmhrd0b+G-u8XtyVt=K2pTJRuFg@mail.gmail.com>
Date: Tue, 21 Jan 2025 20:16:27 +0100
From: Jann Horn <jannh@...gle.com>
To: Kent Overstreet <kent.overstreet@...ux.dev>
Cc: linux-bcachefs@...r.kernel.org, kernel list <linux-kernel@...r.kernel.org>
Subject: Re: kernel build error due to large stack frame in __bch2_str_hash_check_key

On Tue, Jan 21, 2025 at 7:01 PM Kent Overstreet
<kent.overstreet@...ux.dev> wrote:
> On Tue, Jan 21, 2025 at 05:01:26PM +0100, Jann Horn wrote:
> > Hi!
> >
> > I'm trying to build the mainline kernel at commit
> > 95ec54a420b8f445e04a7ca0ea8deb72c51fe1d3 (upstream git master), but
> > the build fails with the following error:
> >
> > ```
> > [...]/fs/bcachefs/str_hash.c: In function ‘__bch2_str_hash_check_key’:
> > [...]/fs/bcachefs/str_hash.c:295:1: error: the frame size of 2400
> > bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> >   295 | }
> >       | ^
> > cc1: all warnings being treated as errors
> > ```
> >
> > I am building with "gcc (Debian 14.2.0-3+build3) 14.2.0", using the
> > attached kernel config. I think this used to work with the mainline
> > kernel before the 6.14 merge window opened.
>
> Well, your kernel config has something that doubles stack frame size,
> it's 1200 bytes here.

It does have things like KASAN and lockdep enabled, it seems plausible
that that could bloat up the stack frames quite a bit.