linux-kernel - Re: [PATCH] perf trace: Remove return value of trace__fprintf_tp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEmfU+tj6kUbRNe7YbCorRStyAKs=7ndj73BvPUpkwA-gcBZCg@mail.gmail.com>
Date: Wed, 22 Jan 2025 11:19:05 -0800
From: Benjamin Peterson <benjamin@...flow.com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Howard Chu <howardchu95@...il.com>, Peter Zijlstra <peterz@...radead.org>, 
	Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>, Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, 
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf trace: Remove return value of trace__fprintf_tp_fields

On Wed, Jan 22, 2025 at 11:08 AM Namhyung Kim <namhyung@...nel.org> wrote:
>
> Hello,
>
> On Tue, Jan 21, 2025 at 07:01:53PM -0800, Howard Chu wrote:
> > Hello fellow maintainers,
> >
> > Just a slight ping.
>
> Thanks for the reminder.

Thanks for taking a look.

>
> >
> > Thanks,
> > Howard
> >
> > On Fri, Dec 13, 2024 at 10:06 AM Howard Chu <howardchu95@...il.com> wrote:
> > >
> > > Hello Benjamin,
> > >
> > > On Thu, Dec 12, 2024 at 7:56 PM Benjamin Peterson <benjamin@...flow.com> wrote:
> > > >
> > > > The return value of this function was meaningless and therefore ignored by
> > > > the caller. Remove it.
>
> In fact, I don't see the reason to merge this, as it's the convention to
> return the number of characters it prints.  Yes, it's not used but not
> much reason to remove it.

The main reason to remove the return value is that it has no useful
interpretation and is therefore confusing. To wit, the function
returns two times the number of bytes it prints.