linux-kernel - Re: [PATCH 2/4] ASoC: SOF: imx: Add mach entry to select cs42888 topology

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z5FNHnwvN+KeUrFY@lizhi-Precision-Tower-5810>
Date: Wed, 22 Jan 2025 14:55:10 -0500
From: Frank Li <Frank.li@....com>
To: Daniel Baluta <daniel.baluta@....com>
Cc: robh@...nel.org, krzk+dt@...nel.org, broonie@...nel.org,
	shawnguo@...nel.org, conor+dt@...nel.org, peng.fan@....com,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	lgirdwood@...il.com, peter.ujfalusi@...ux.intel.com,
	linux-sound@...r.kernel.org, imx@...ts.linux.dev,
	Liam Girdwood <liam.r.girdwood@...el.com>,
	Bard Liao <yung-chuan.liao@...ux.intel.com>,
	Iuliana Prodan <iuliana.prodan@....com>,
	Laurentiu Mihalcea <laurentiu.mihalcea@....com>
Subject: Re: [PATCH 2/4] ASoC: SOF: imx: Add mach entry to select cs42888
 topology

On Wed, Jan 22, 2025 at 06:35:42PM +0200, Daniel Baluta wrote:
> After commit 2b9cdef13648 ("ASoC: SOF: imx: Add devicetree support
> to select topologies") we select topology to be used by the board
> compatible string in the dts.

I am confused. why not use "sof-imx8-cs42888.tplg" in imx8's dts instead
use board's compatible string "fsl,imx8qxp-mek-bb".

More and more boards will be added in future. This file will become bigger
and bigger!

Frank

>
> Now that we have a way to know when the baseboard is installed, use
> the board compatible and select proper topology files when the cs42888
> Audio IO card is used.
>
> Reviewed-by: Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>
> Reviewed-by: Liam Girdwood <liam.r.girdwood@...el.com>
> Reviewed-by: Bard Liao <yung-chuan.liao@...ux.intel.com>
> Reviewed-by: Iuliana Prodan <iuliana.prodan@....com>
> Reviewed-by: Laurentiu Mihalcea <laurentiu.mihalcea@....com>
> Signed-off-by: Daniel Baluta <daniel.baluta@....com>
> ---
>  sound/soc/sof/imx/imx8.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/sound/soc/sof/imx/imx8.c b/sound/soc/sof/imx/imx8.c
> index 0b85b29d1067..d6117a3d4266 100644
> --- a/sound/soc/sof/imx/imx8.c
> +++ b/sound/soc/sof/imx/imx8.c
> @@ -611,6 +611,17 @@ static struct snd_sof_of_mach sof_imx8_machs[] = {
>  		.sof_tplg_filename = "sof-imx8-wm8960.tplg",
>  		.drv_name = "asoc-audio-graph-card2",
>  	},
> +	{
> +		.compatible = "fsl,imx8qxp-mek-bb",
> +		.sof_tplg_filename = "sof-imx8-cs42888.tplg",
> +		.drv_name = "asoc-audio-graph-card2",
> +	},
> +	{
> +		.compatible = "fsl,imx8qm-mek-bb",
> +		.sof_tplg_filename = "sof-imx8-cs42888.tplg",
> +		.drv_name = "asoc-audio-graph-card2",
> +	},
> +
>  	{}
>  };
>
> --
> 2.43.0
>