linux-kernel - Re: [PATCH] drm/panel-edp: Add STA 116QHD024002

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=WXYUoWxgpktxp=nniq4bzD0GZsZ5i6-G7hbxwb2SpPTg@mail.gmail.com>
Date: Wed, 22 Jan 2025 12:41:29 -0800
From: Doug Anderson <dianders@...omium.org>
To: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
Cc: neil.armstrong@...aro.org, quic_jesszhan@...cinc.com, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, 
	airlied@...il.com, simona@...ll.ch, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel-edp: Add STA 116QHD024002

Hi,

On Wed, Jan 22, 2025 at 12:23 AM Langyan Ye
<yelangyan@...qin.corp-partner.google.com> wrote:
>
> Add support for the STA 116QHD024002, pleace the EDID here for
> subsequent reference.
>
> 00 ff ff ff ff ff ff 00 4e 81 09 00 00 00 00 00
> 26 21 01 04 a5 1a 0e 78 02 1e b5 9a 5f 57 94 26
> 0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 8e 1c 56 a0 50 00 1e 30 28 20
> 55 00 00 90 10 00 00 18 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 fe 00 20
> 20 20 20 20 20 0a 20 20 20 20 20 20 00 00 00 fe
> 00 31 31 36 51 48 44 30 32 34 30 30 32 0a 00 3b
>
> Signed-off-by: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 1721a3397dbf..73b8938f175b 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1808,6 +1808,13 @@ static const struct panel_delay delay_200_150_e50 = {
>         .enable = 50,
>  };
>
> +static const struct panel_delay delay_200_500_e250_po2e200 = {
> +       .hpd_absent = 200,
> +       .unprepare = 500,
> +       .enable = 250,
> +       .powered_on_to_enable = 200,
> +};

I don't believe you need "powered_on_to_enable" here. The docs for
"powered_on_to_enable" say:

* This doesn't normally need to be set if timings are already met by
* prepare_to_enable or enable.

In this case "enable" is 250 ms, which subsumes the 200 ms
"powered_on_to_enable".

Can you confirm and then re-post without the "powered_on_to_enable" setting?

Thanks!

-Doug