[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <db76d5ab-3eda-439d-8b92-c0423d1e39c8@alliedtelesis.co.nz>
Date: Wed, 22 Jan 2025 20:53:08 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: "lee@...nel.org" <lee@...nel.org>, "robh@...nel.org" <robh@...nel.org>,
"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
<conor+dt@...nel.org>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
"pabeni@...hat.com" <pabeni@...hat.com>, "tsbogend@...ha.franken.de"
<tsbogend@...ha.franken.de>, "hkallweit1@...il.com" <hkallweit1@...il.com>,
"linux@...linux.org.uk" <linux@...linux.org.uk>, "sander@...nheule.net"
<sander@...nheule.net>, "markus.stockhausen@....de"
<markus.stockhausen@....de>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org"
<netdev@...r.kernel.org>, "linux-mips@...r.kernel.org"
<linux-mips@...r.kernel.org>
Subject: Re: [PATCH v4 2/4] dt-bindings: mfd: Add MDIO interface to
rtl9301-switch
On 22/01/2025 21:14, Krzysztof Kozlowski wrote:
> On Mon, Jan 20, 2025 at 05:02:12PM +1300, Chris Packham wrote:
>> The MDIO controller is part of the switch on the RTL9300 family of
>> devices. Add a $ref to the mfd binding for these devices.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>> ---
>>
> You need to explain merging dependencies. Nothing in cover letter,
> nothing here, but this *CANNOT* be merged independently.
OK. I'll make sure to add a note here and to the series cover letter.
>> Notes:
>> Changes in v4:
>> - There is a single MDIO controller that has MDIO buses as children
>> Changes in v3:
>> - None
>> Changes in v2:
>> - None
>>
>> .../bindings/mfd/realtek,rtl9301-switch.yaml | 24 +++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
>> index f053303ab1e6..c19d2c209434 100644
>> --- a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
>> @@ -28,6 +28,9 @@ properties:
>> reg:
>> maxItems: 1
>>
>> + mdio-controller:
>> + $ref: /schemas/net/realtek,rtl9301-mdio.yaml#
>> +
>> '#address-cells':
>> const: 1
>>
>> @@ -110,5 +113,26 @@ examples:
>> };
>> };
>> };
>> +
>> + mdio-controller {
> No, no resources here, no unit address. Look at other nodes - they have
> the resource, the address. Mixing such nodes is clear indication this is
> not correct hardware description and you do this only for Linux.
>
> Fold child device into parent.
In this particular case all the mdio stuff is actually contained to a
range starting at offset 0xca00. I dropped it because it was simpler in
the driver to use the full 16-bit address rather than trying to use
offsets from the base address that didn't correspond to the datasheet.
As you've highlighted that's making the dt-binding impose driver
specifics so would adding back `mdio-controller@...0` and `reg = <0xca00
0x200>;` be OK even if the driver doesn't actually use them?
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists