linux-kernel - Re: [PATCH] dt-bindings: omap: Add TI Pandaboard A4 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250122232010.1a5a0525@akair>
Date: Wed, 22 Jan 2025 23:20:10 +0100
From: Andreas Kemnade <andreas@...nade.info>
To: Tom Rini <trini@...sulko.com>
Cc: linux-kernel@...r.kernel.org, Aaro Koskinen <aaro.koskinen@....fi>,
 Kevin Hilman <khilman@...libre.com>, Roger Quadros <rogerq@...nel.org>,
 Tony Lindgren <tony@...mide.com>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 linux-omap@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: omap: Add TI Pandaboard A4 variant

Am Wed, 22 Jan 2025 08:20:58 -0600
schrieb Tom Rini <trini@...sulko.com>:

> On Wed, Jan 22, 2025 at 09:32:36AM +0100, Andreas Kemnade wrote:
> > Am Tue, 21 Jan 2025 18:12:40 -0600
> > schrieb Tom Rini <trini@...sulko.com>:
> >   
> > > Document the ti,omap4-panda-a4 compatible string in the appropriate
> > > place within the omap family binding file.
> > > 
> > > Signed-off-by: Tom Rini <trini@...sulko.com>
> > > ---
> > > Cc: Aaro Koskinen <aaro.koskinen@....fi>
> > > Cc: Andreas Kemnade <andreas@...nade.info>
> > > Cc: Kevin Hilman <khilman@...libre.com>
> > > Cc: Roger Quadros <rogerq@...nel.org>
> > > Cc: Tony Lindgren <tony@...mide.com>
> > > Cc: Rob Herring <robh@...nel.org>
> > > Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>
> > > Cc: Conor Dooley <conor+dt@...nel.org>
> > > Cc: linux-omap@...r.kernel.org
> > > Cc: devicetree@...r.kernel.org
> > > Cc: linux-kernel@...r.kernel.org
> > > ---
> > >  Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > > index 93e04a109a12..28e23ca766b4 100644
> > > --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > > @@ -137,6 +137,7 @@ properties:
> > >                - motorola,xyboard-mz609
> > >                - motorola,xyboard-mz617
> > >                - ti,omap4-panda
> > > +              - ti,omap4-panda-a4
> > >                - ti,omap4-sdp
> > >            - const: ti,omap4430
> > >            - const: ti,omap4  
> > 
> > This allows compatible = "ti,omap4-panda-a4", "ti,omap4430", "ti,omap4"
> > 
> > According to your other patch, you want
> > compatible = "ti,omap4-panda-a4", "ti,omap4-panda", "ti,omap4430",
> > "ti,omap4"
> > 
> > so you need a construction similar to the "ti,omap3-beagle-ab4"  
> 
> Do you mean the order should change, or it should be an enum? I'm not
> sure where this is documented (the $id and $schema values in the file
> are just 404s so I guess not something to read directly?).
> 
you would need a block like this:

      - description: Early Pandaboard revision A4
        items:
          - const: ti,omap4-panda-a4
          - const: ti,omap4-panda
          - const: ti,omap4430
          - const: ti,omap4


Regards,
Andreas