linux-kernel - Re: [PATCH] KVM: x86: switch hugepage recovery thread to vhost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87msfijx7y.fsf@alyssa.is>
Date: Wed, 22 Jan 2025 23:32:49 +0100
From: Alyssa Ross <hi@...ssa.is>
To: Keith Busch <kbusch@...nel.org>
Cc: Paolo Bonzini <pbonzini@...hat.com>, Sean Christopherson
 <seanjc@...gle.com>, linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
 michael.christie@...cle.com, Tejun Heo <tj@...nel.org>, Luca Boccassi
 <bluca@...ian.org>, stable@...r.kernel.org, regressions@...ts.linux.dev
Subject: Re: [PATCH] KVM: x86: switch hugepage recovery thread to vhost_task

Keith Busch <kbusch@...nel.org> writes:

> On Wed, Jan 22, 2025 at 12:38:25PM +0100, Alyssa Ross wrote:
>> On Wed, Jan 15, 2025 at 12:03:27PM -0700, Keith Busch wrote:
>> > On Wed, Jan 15, 2025 at 06:10:05PM +0100, Paolo Bonzini wrote:
>> > > You can implement something like pthread_once():
>> >
>> > ...
>> >
>> > > Where to put it I don't know.  It doesn't belong in
>> > > include/linux/once.h.  I'm okay with arch/x86/kvm/call_once.h and just
>> > > pull it with #include "call_once.h".
>> >
>> > Thanks for the suggestion, I can work with that. As to where to put it,
>> > I think the new 'struct once' needs to be a member of struct kvm_arch,
>> > so I've put it in arch/x86/include/asm/.
>> >
>> > Here's the result with that folded in. If this is okay, I'll send a v2,
>> > and can split out the call_once as a prep patch with your attribution if
>> > you like.
>> 
>> Has there been any progress here?  I'm also affected by the crosvm
>> regression, and it's been backported to the LTS stable kernel.
>
> Would you be able to try the proposed patch here and reply with a
> Tested-by if it's successful for you? I'd also like to unblock this,
> whether this patch is in the right direction or try something else.

Sure!  I can confirm this patch fixes crosvm for me when applied to 6.13.

Tested-by: Alyssa Ross <hi@...ssa.is>

Download attachment "signature.asc" of type "application/pgp-signature" (228 bytes)