linux-kernel - Re: [PATCH] block: mtip32xx: Remove unnecessary function calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b8d974b-58b6-49f7-9101-5fd5c33750d8@kernel.org>
Date: Wed, 22 Jan 2025 15:02:19 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Philipp Stanner <phasta@...nel.org>, Jens Axboe <axboe@...nel.dk>,
 Hannes Reinecke <hare@...e.de>, John Garry <john.g.garry@...cle.com>,
 Li Zetao <lizetao1@...wei.com>, Al Viro <viro@...iv.linux.org.uk>
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: mtip32xx: Remove unnecessary function calls

On 1/21/25 1:20 AM, Philipp Stanner wrote:
> pcim_iounmap_regions() does not have to be called, because the regions
> are automatically unmapped since they were mapped with managed
> functions. Moreover, that function is deprecated anyways.
> 
> Furthermore, setting the drvdata to NULL is unnecessary in a driver
> remove() function.
> 
> Remove the unnecessary calls.
> 
> Signed-off-by: Philipp Stanner <phasta@...nel.org>

Looks OK to me.

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>

-- 
Damien Le Moal
Western Digital Research