| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <19d34aba-2ded-4aa3-b76f-5120ad669720@kernel.org>
Date: Wed, 22 Jan 2025 07:17:15 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: linux@...blig.org, gregkh@...uxfoundation.org
Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty/ldsem: Remove unused ldsem_down_write_trylock
On 22. 01. 25, 2:25, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> ldsem_down_write_trylock() was added in 2013 by
> commit 4898e640caf0 ("tty: Add timed, writer-prioritized rw semaphore")
> but hasn't been used.
>
> Remove it.
Right, it was likely added for symmetry. However having untested+unused
code is indeed wrong.
Reviewed-by: Jiri Slaby <jirislaby@...nel.org>
thanks,
--
js
suse labs
Powered by blists - more mailing lists