linux-kernel - Re: [PATCH] f2fs: fix to avoid changing 'check only' behaior of recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9edcabc6-bfaa-48ea-ab59-54180d6c62c7@kernel.org>
Date: Wed, 22 Jan 2025 14:27:42 +0800
From: Chao Yu <chao@...nel.org>
To: Zhiguo Niu <zhiguo.niu@...soc.com>, jaegeuk@...nel.org
Cc: chao@...nel.org, linux-f2fs-devel@...ts.sourceforge.net,
 linux-kernel@...r.kernel.org, niuzhiguo84@...il.com, ke.wang@...soc.com,
 Hao_hao.Wang@...soc.com
Subject: Re: [PATCH] f2fs: fix to avoid changing 'check only' behaior of
 recovery

On 1/21/25 10:15, Zhiguo Niu wrote:
> The following two 'check only recovery' processes are very dependent on
> the return value of f2fs_recover_fsync_data, especially when the return
> value is greater than 0.
> 1. when device has readonly mode, shown as commit
> 23738e74472f ("f2fs: fix to restrict mount condition on readonly block device")
> 2. mount optiont NORECOVERY or DISABLE_ROLL_FORWARD is set, shown as commit
> 6781eabba1bd ("f2fs: give -EINVAL for norecovery and rw mount")
> 
> However, commit c426d99127b1 ("f2fs: Check write pointer consistency of open zones")
> will change the return value unexpectedly, thereby changing the caller's behavior
> 
> This patch let the f2fs_recover_fsync_data return correct value,and not do
> f2fs_check_and_fix_write_pointer when the device is read-only.
> 
> Fixes: c426d99127b1 ("f2fs: Check write pointer consistency of open zones")
> Signed-off-by: Zhiguo Niu <zhiguo.niu@...soc.com>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,