linux-kernel - Re: [PATCH v1] i2c: qcom-geni: Update i2c frequency table to match hardware guidance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b708832b-a0c2-4a1b-88a8-0257b1d22fda@linaro.org>
Date: Wed, 22 Jan 2025 09:01:30 +0200
From: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
To: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>, andi.shyti@...nel.org,
 linux-arm-msm@...r.kernel.org, linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] i2c: qcom-geni: Update i2c frequency table to match
 hardware guidance

On 1/22/25 08:46, Mukesh Kumar Savaliya wrote:
> With the current settings, the I2C buses are achieving around 370KHz
> instead of the expected 400KHz. For 100KHz and 1MHz, the settings are
> now more compliant and adhere to the Qualcomm’s internal programming
> guide.
> 
> Update the I2C frequency table to align with the recommended values
> outlined in the I2C hardware programming guide, ensuring proper
> communication and performance.
> 
> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
> ---
>   drivers/i2c/busses/i2c-qcom-geni.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index 7a22e1f46e60..cc0c683febbb 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -148,9 +148,9 @@ struct geni_i2c_clk_fld {
>    * source_clock = 19.2 MHz
>    */
>   static const struct geni_i2c_clk_fld geni_i2c_clk_map_19p2mhz[] = {
> -	{KHZ(100), 7, 10, 11, 26},
> -	{KHZ(400), 2,  5, 12, 24},
> -	{KHZ(1000), 1, 3,  9, 18},
> +	{KHZ(100), 7, 10, 12, 26},
> +	{KHZ(400), 2,  5, 11, 22},
> +	{KHZ(1000), 1, 2,  8, 18},
>   	{},
>   };
>   

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>

--
Best wishes,
Vladimir