linux-kernel - Re: [PATCH v3 1/2] dt-bindings: memory: mediatek: Add SMI reset and clamp for MT8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0aaa718aa4158cb5b276efa0529262d96db6b82.camel@mediatek.com>
Date: Wed, 22 Jan 2025 07:39:28 +0000
From: Friday Yang (杨阳) <Friday.Yang@...iatek.com>
To: "krzk@...nel.org" <krzk@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	Yong Wu (吴勇) <Yong.Wu@...iatek.com>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: memory: mediatek: Add SMI reset and
 clamp for MT8188

On Tue, 2025-01-21 at 11:14 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Tue, Jan 21, 2025 at 02:49:26PM +0800, Friday Yang wrote:
> > From: "friday.yang" <friday.yang@...iatek.com>
> > 
> > Add 'resets' and 'reset-names' properties for SMI LARBs to support
> > SMI reset operations.
> > On the MediaTek platform, some SMI LARBs are directly connected to
> > the SMI Common, while others are connected to the SMI Sub-Common,
> > which in turn is connected to the SMI Common. The hardware block
> > diagram can be described as follows.
> > 
> >              SMI-Common(Smart Multimedia Interface Common)
> >                  |
> >          +----------------+------------------+
> >          |                |                  |
> >          |                |                  |
> >          |                |                  |
> >          |                |                  |
> >          |                |                  |
> >        larb0       SMI-Sub-Common0     SMI-Sub-Common1
> >                    |      |     |      |             |
> >                   larb1  larb2 larb3  larb7       larb9
> > 
> > Signed-off-by: Friday Yang <friday.yang@...iatek.com>
> 
> SoB/From mismatch.
> 
> Please run scripts/checkpatch.pl and fix reported warnings. After
> that,
> run also 'scripts/checkpatch.pl --strict' and (probably) fix more
> warnings. Some warnings can be ignored, especially from --strict run,
> but the code here looks like it needs a fix. Feel free to get in
> touch
> if the warning is not clear.
> 

Thanks for kindly remind, I will fix the signed name mismatch error and
check the patch again.

> Best regards,
> Krzysztof
>