linux-kernel - Re: [RFC v3 01/18] dt-bindings: clock: Add VO subsystem clock controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99c1ac06-cbb4-4319-b006-9f7095509803@kernel.org>
Date: Wed, 22 Jan 2025 08:44:07 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Michal Wilczynski <m.wilczynski@...sung.com>
Cc: mturquette@...libre.com, sboyd@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, drew@...7.com, guoren@...nel.org,
 wefu@...hat.com, jassisinghbrar@...il.com, paul.walmsley@...ive.com,
 palmer@...belt.com, aou@...s.berkeley.edu, frank.binns@...tec.com,
 matt.coster@...tec.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
 ulf.hansson@...aro.org, jszhang@...nel.org, p.zabel@...gutronix.de,
 m.szyprowski@...sung.com, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-riscv@...ts.infradead.org, dri-devel@...ts.freedesktop.org,
 linux-pm@...r.kernel.org
Subject: Re: [RFC v3 01/18] dt-bindings: clock: Add VO subsystem clock
 controller support

On 21/01/2025 22:29, Michal Wilczynski wrote:
> 
> 
> On 1/21/25 10:47, Krzysztof Kozlowski wrote:
>> On Mon, Jan 20, 2025 at 06:20:54PM +0100, Michal Wilczynski wrote:
>>>  properties:
>>>    compatible:
>>> -    const: thead,th1520-clk-ap
>>> +    enum:
>>> +      - thead,th1520-clk-ap
>>> +      - thead,th1520-clk-vo
>>>  
>>>    reg:
>>>      maxItems: 1
>>>  
>>>    clocks:
>>>      items:
>>> -      - description: main oscillator (24MHz)
>>> +      - description: main oscillator (24MHz) or CLK_VIDEO_PLL
>>
>> thead,th1520-clk-ap gets also VIDEO_PLL? Aren't both serving the same
>> purpose from these devices point of view? Bindings are telling what this
>> device is expecting.
> 
> Since thead,th1520-clk-ap configures PLL clocks it takes the oscillator
> 24MHz as an input, so no.
> 
> The VO subsystem takes as an input VIDEO_PLL that's configured by the
> AP.

I understood that, but you really did not answer to my question. How is
the input called? Not how is the clock called.

> 
> I could do something like this if this needs to be formally expressed in
> the schema:

It is enough to put it in description.



Best regards,
Krzysztof