linux-kernel - Re: [PATCH v1 00/21] hwmon: Fix the type of 'config' in struct hwmon_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4959c2c0-564a-4e3c-9650-228dede9a1f9@kernel.org>
Date: Wed, 22 Jan 2025 08:51:29 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "lihuisong (C)" <lihuisong@...wei.com>, linux-hwmon@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, arm-scmi@...r.kernel.org,
 netdev@...r.kernel.org, linux-rtc@...r.kernel.org, oss-drivers@...igine.com,
 linux-rdma@...r.kernel.org, platform-driver-x86@...r.kernel.org,
 linuxarm@...wei.com, linux@...ck-us.net, jdelvare@...e.com,
 kernel@...davale.org, pauk.denis@...il.com, james@...iv.tech,
 sudeep.holla@....com, cristian.marussi@....com, matt@...ostay.sg,
 mchehab@...nel.org, irusskikh@...vell.com, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, saeedm@...dia.com, leon@...nel.org, tariqt@...dia.com,
 louis.peens@...igine.com, hkallweit1@...il.com, linux@...linux.org.uk,
 kabel@...nel.org, W_Armin@....de, hdegoede@...hat.com,
 ilpo.jarvinen@...ux.intel.com, alexandre.belloni@...tlin.com,
 jonathan.cameron@...wei.com, zhanjie9@...ilicon.com,
 zhenglifeng1@...wei.com, liuyonglong@...wei.com
Subject: Re: [PATCH v1 00/21] hwmon: Fix the type of 'config' in struct
 hwmon_channel_info to u64

On 21/01/2025 09:14, lihuisong (C) wrote:
> 
> 在 2025/1/21 15:47, Krzysztof Kozlowski 写道:
>> On 21/01/2025 07:44, Huisong Li wrote:
>>> The hwmon_device_register() is deprecated. When I try to repace it with
>>> hwmon_device_register_with_info() for acpi_power_meter driver, I found that
>>> the power channel attribute in linux/hwmon.h have to extend and is more
>>> than 32 after this replacement.
>>>
>>> However, the maximum number of hwmon channel attributes is 32 which is
>>> limited by current hwmon codes. This is not good to add new channel
>>> attribute for some hwmon sensor type and support more channel attribute.
>>>
>>> This series are aimed to do this. And also make sure that acpi_power_meter
>>> driver can successfully replace the deprecated hwmon_device_register()
>>> later.
>> Avoid combining independent patches into one patch bomb. Or explain the
>> dependencies and how is it supposed to be merged - that's why you have
>> cover letter here.
> These patches having a title ('Use HWMON_CHANNEL_INFO macro to simplify 
> code') are also for this series.
> Or we need to modify the type of the 'xxx_config' array in these patches.
> If we directly use the macro HWMON_CHANNEL_INFO, the type of 'config' 
> has been modifyed in patch 1/21 and these driver don't need to care this 
> change.

None of above addresses my concern. I am dropping the series from my
inbox/to-review box.

Best regards,
Krzysztof