linux-kernel - Re: [RFC v3 07/18] dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05b8ae46-f8af-413f-8870-ab1997c8f5b9@kernel.org>
Date: Wed, 22 Jan 2025 09:22:24 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Michal Wilczynski <m.wilczynski@...sung.com>,
 Philipp Zabel <p.zabel@...gutronix.de>, mturquette@...libre.com,
 sboyd@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 drew@...7.com, guoren@...nel.org, wefu@...hat.com, jassisinghbrar@...il.com,
 paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu,
 frank.binns@...tec.com, matt.coster@...tec.com,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
 airlied@...il.com, simona@...ll.ch, ulf.hansson@...aro.org,
 jszhang@...nel.org, m.szyprowski@...sung.com
Cc: linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 dri-devel@...ts.freedesktop.org, linux-pm@...r.kernel.org
Subject: Re: [RFC v3 07/18] dt-bindings: reset: Add T-HEAD TH1520 SoC Reset
 Controller

On 21/01/2025 22:58, Michal Wilczynski wrote:
>>> +maintainers:
>>> +  - Michal Wilczynski <m.wilczynski@...sung.com>
>>> +
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - thead,th1520-reset
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  "#reset-cells":
>>> +    const: 0
>>
>> Should this be "const: 1" instead?
> 
> Right now I'm not planning to extend by more resets, I've thought about
> this during the discussion on v2 of this patchset. At this point I just
> can't see more interesting resets to have. Vendor kernel implements WDT
> and NPU. I don't think NPU driver will be upstream anytime soon. That
> would leave WDT reset potentially.

Bindings should be complete, regardless whether you implement reset
consumer driver or not.

Best regards,
Krzysztof