linux-kernel - Re: [PATCH] ARM: dts: omap4-panda-a4: Add missing model and compatible properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250122000824.GJ3476@bill-the-cat>
Date: Tue, 21 Jan 2025 18:08:24 -0600
From: Tom Rini <trini@...sulko.com>
To: Kevin Hilman <khilman@...nel.org>
Cc: linux-kernel@...r.kernel.org, Nishanth Menon <nm@...com>,
	Tony Lindgren <tony@...mide.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-omap@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: omap4-panda-a4: Add missing model and
 compatible properties

On Tue, Jan 21, 2025 at 02:50:41PM -0800, Kevin Hilman wrote:
> Hi Tom,
> 
> Tom Rini <trini@...sulko.com> writes:
> 
> > When moving the model and compatible properties out of the common
> > Pandaboard files and in to the specific boards, the omap4-panda-a4
> > file wasn't updated as well and so has lacked a model and compatible
> > entry ever since.
> >
> > Fixes: a1a57abaaf82 ("ARM: dts: omap4-panda: Fix model and SoC family details")
> > Signed-off-by: Tom Rini <trini@...sulko.com>
> > ---
> 
> Checkpatch tells me:
> 
>  WARNING: DT compatible string "ti,omap4-panda-a4" appears un-documented
> 
> So I think Documentation/devicetree/bindings/arm/ti/omap.yaml needs an
> update too.  (and note the binding update should be a separate patch[1])

Regular panda is there, so yeah, it's easy enough to add the a4 variant.
I assume if I post that they'll get merged in the right order?

> > Given how long this has been broken it's entirely plausible no a4
> > hardware even exists anymore and so dropping this file instead makes
> > sense. I only found this because scripts/make_fit.py crashed on these
> > properties being missing.
> 
> If keeping it is just this binding update, then I'd say we keep it, but
> if it gets any more paninful to maintain, I'm also not going to argue
> very hard to keep it.

I'm not in the position to see if any of the Pandaboards work at this
point, so I don't know if they're otherwise functional or a huge pile of
problems.

-- 
Tom

Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)